-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add project ID to the fleet feature membership for ASM #1832
fix: Add project ID to the fleet feature membership for ASM #1832
Conversation
Thanks @legal90! @ferrarimarco would you be able to review? /gcbrun |
58b0783
to
2ef7031
Compare
It fixes this error: > * Failed to retrieve project, pid: , err: project: required field is not set
2ef7031
to
f878b05
Compare
Hi! I'll have a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/gcbrun |
/gcbrun |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @legal90!
Thanks for the review @ferrarimarco!
…m-google-modules#1832) Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
That resource was added recently in #1702
Bit I get this error when I try to apply it with my config:
I fix it in this PR just by adding
project
argument explicitly.After that fix it works as expected.
cc @ferrarimarco